Thread (19 messages) 19 messages, 4 authors, 2025-07-17

Re: [PATCH v2 06/10] dt-bindings: display: imx: Add bindings for i.MX94 DCIF

From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-07-16 19:41:02
Also in: dri-devel, imx, linux-devicetree, lkml

On 16/07/2025 10:15, Laurentiu Palcu wrote:
DCIF is the i.MX94 Display Controller Interface which is used to
drive a TFT LCD panel or connects to a display interface depending
on the chip configuration.

Signed-off-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>

...
+
+  interrupts:
+    items:
+      - description:
+          Interrupt output for CPU domain 0 (controlled by common registers group).
+      - description:
+          Interrupt output for CPU domain 1 (controlled by background layer registers group).
+      - description:
+          Interrupt output for CPU domain 2 (controlled by foreground layer registers group).

Keep these in one line with description, by dropping redundant part
"Interrupt output for".
+
+  interrupt-names:
+    items:
+      - const: common
+      - const: bg_layer
+      - const: fg_layer
+
+  clocks:
+    items:
+      - description: APB bus clock
+      - description: AXI bus clock
+      - description: Pixel clock
+
+  clock-names:
+    items:
+      - const: apb
+      - const: axi
+      - const: pix
+
+  power-domains:
+    maxItems: 1
+
+  nxp,blk-ctrl:
+    $ref: /schemas/types.yaml#/definitions/phandle
+    description: A phandle which points to NXP displaymix blk-ctrl.

Describe for what purpose (from hardware point of view)

With these improvements:

Reviewed-by: Krzysztof Kozlowski <redacted>
+
+  port:
+    $ref: /schemas/graph.yaml#/properties/port
+    description: Display Pixel Interface(DPI) output port
+

Best regards,
Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help