On Wed, 2 Jul 2025 13:01:04 +0800
Chen-Yu Tsai [off-list ref] wrote:

On Wed, Jul 2, 2025 at 12:58 AM Chen-Yu Tsai [off-list ref] wrote:

quoted

From: Chen-Yu Tsai <redacted>

Until now, if the system controller had a ethernet controller glue
layer control register, a limited access regmap would be registered
and tied to the system controller struct device for the ethernet
driver to use.

"Until now"? 
Does that description (i.e. something that used to happen, but not
after the patch) really match the change?

- snip -

quoted

+               ret = of_syscon_register_regmap(dev->of_node,
regmap);
+               if (IS_ERR(ret))  

BroderTuck on IRC pointed out that this gives a compiler warning.
Indeed it is incorrect. It should test `ret` directly.

ChenYu

Regards
Per Larsson, known as BroderTuck on #linux-sunxi