Re: [PATCH RFT net-next 04/10] soc: sunxi: sram: register regmap as syscon
From: Chen-Yu Tsai <hidden>
Date: 2025-07-02 05:01:22
Also in:
linux-devicetree, linux-sunxi, lkml, netdev
On Wed, Jul 2, 2025 at 12:58 AM Chen-Yu Tsai [off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Chen-Yu Tsai <redacted> Until now, if the system controller had a ethernet controller glue layer control register, a limited access regmap would be registered and tied to the system controller struct device for the ethernet driver to use. Signed-off-by: Chen-Yu Tsai <redacted> --- drivers/soc/sunxi/sunxi_sram.c | 6 ++++++ 1 file changed, 6 insertions(+)diff --git a/drivers/soc/sunxi/sunxi_sram.c b/drivers/soc/sunxi/sunxi_sram.c index 4f8d510b7e1e..63c23bdffa78 100644 --- a/drivers/soc/sunxi/sunxi_sram.c +++ b/drivers/soc/sunxi/sunxi_sram.c@@ -12,6 +12,7 @@ #include <linux/debugfs.h> #include <linux/io.h> +#include <linux/mfd/syscon.h> #include <linux/module.h> #include <linux/of.h> #include <linux/of_address.h>@@ -377,6 +378,7 @@ static int __init sunxi_sram_probe(struct platform_device *pdev) const struct sunxi_sramc_variant *variant; struct device *dev = &pdev->dev; struct regmap *regmap; + int ret; sram_dev = &pdev->dev;@@ -394,6 +396,10 @@ static int __init sunxi_sram_probe(struct platform_device *pdev) regmap = devm_regmap_init_mmio(dev, base, &sunxi_sram_regmap_config); if (IS_ERR(regmap)) return PTR_ERR(regmap); + + ret = of_syscon_register_regmap(dev->of_node, regmap); + if (IS_ERR(ret))
BroderTuck on IRC pointed out that this gives a compiler warning. Indeed it is incorrect. It should test `ret` directly. ChenYu
+ return ret;
}
of_platform_populate(dev->of_node, NULL, NULL, dev);
--
2.39.5