Thread (15 messages) 15 messages, 5 authors, 2025-07-04

Re: [PATCH 1/5] pinctrl: sunxi: v3s: Fix wrong comment about UART2 pinmux

From: Icenowy Zheng <hidden>
Date: 2025-07-02 03:05:06
Also in: dri-devel, linux-clk, linux-devicetree, linux-gpio, linux-media, linux-sunxi, lkml

在 2025-07-01星期二的 22:11 +0200,Paul Kocialkowski写道:
quoted hunk ↗ jump to hunk
The original comment doesn't match the pin attribution, probably due
to a hasty copy/paste.

Signed-off-by: Paul Kocialkowski <paulk@sys-base.io>
---
 drivers/pinctrl/sunxi/pinctrl-sun8i-v3s.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/sunxi/pinctrl-sun8i-v3s.c
b/drivers/pinctrl/sunxi/pinctrl-sun8i-v3s.c
index 696d7dd8d87b..2e3bd36a4410 100644
--- a/drivers/pinctrl/sunxi/pinctrl-sun8i-v3s.c
+++ b/drivers/pinctrl/sunxi/pinctrl-sun8i-v3s.c
@@ -45,7 +45,7 @@ static const struct sunxi_desc_pin sun8i_v3s_pins[]
= {
        SUNXI_PIN(SUNXI_PINCTRL_PIN(B, 3),
                  SUNXI_FUNCTION(0x0, "gpio_in"),
                  SUNXI_FUNCTION(0x1, "gpio_out"),
-                 SUNXI_FUNCTION(0x2, "uart2"),         /* D1 */
+                 SUNXI_FUNCTION(0x2, "uart2"),         /* CTS */
LGTM. Blame to my ADHD ;-)

Reviewed-by: Icenowy Zheng <redacted>
                  SUNXI_FUNCTION_IRQ_BANK(0x6, 0, 3)),  /* PB_EINT3
*/
        SUNXI_PIN(SUNXI_PINCTRL_PIN(B, 4),
                  SUNXI_FUNCTION(0x0, "gpio_in"),
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help