On Wed, 2025-06-11 at 11:32 +0200, Krzysztof Kozlowski wrote:

External email : Please do not click links or open attachments until
you have verified the sender or the content.


On 14/05/2025 12:54, Krzysztof Kozlowski wrote:

quoted

On 14/05/2025 10:11, Darren.Ye wrote:

quoted

From: Darren Ye <redacted>

Add mt8196 audio AFE document.

A nit, subject: drop second/last, redundant "document".
See also:

https://urldefense.com/v3/__https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst*L18__;Iw!!CTRNKA9wMg0ARbw!l3YASE64DTMTp8bOMry9UyBMf-IcYFTvXOlP2DXfpeUEFdQK79xGYEnsxnJuMihVX7_WhEe3q1evSg$

Since you asked what did you miss from previous review (and I replied
that EVERYTHING) then maybe this will help:

How did you implement this?

My mistake, please forgive my carelessness. I will change it to 
ASoC: dt-bindings: mediatek,mt8196-afe: Add suport for MT8196 audio AFE
controller

THis patch adds initial supoprt for the audio AFE(Audio Front End)
controller on the Mediatek MT8196 platform.

quoted

quoted

Signed-off-by: Darren Ye <redacted>

...

quoted

+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - mediatek,vlpcksys
+  - power-domains
+  - memory-region
+  - clocks
+  - clock-names

Keep the same order as in properties:.

How did you implement this?

I have already made the change here. The "required" fields have been
sorted according to the order of the properties.

quoted

Reviewed-by: Krzysztof Kozlowski <redacted>

How did you implement this?

Sorry, I got it now. I will add it to the commit.

quoted

<form letter>
This is an automated instruction, just in case, because many review
tags
are being ignored. If you know the process, you can skip it (please
do
not feel offended by me posting it here - no bad intentions
intended).
If you do not know the process, here is a short explanation:

Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions
of patchset, under or above your Signed-off-by tag, unless patch
changed
significantly (e.g. new properties added to the DT bindings). Tag
is
"received", when provided in a message replied to you on the
mailing
list. Tools like b4 can help here. However, there's no need to
repost
patches *only* to add the tags. The upstream maintainer will do
that for
tags received on the version they apply.

Full context and explanation:

https://urldefense.com/v3/__https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst*L577__;Iw!!CTRNKA9wMg0ARbw!l3YASE64DTMTp8bOMry9UyBMf-IcYFTvXOlP2DXfpeUEFdQK79xGYEnsxnJuMihVX7_WhEcicLV6xg$

How did you implement this?

Got it.

Does such questions help you to find what was missing?

Best regards,
Krzysztof

I'm very sorry, this is my first time upstreaming. Thank you for your
patient guidance.

Best Regards,
Darren