On 14/05/2025 12:54, Krzysztof Kozlowski wrote:

On 14/05/2025 10:11, Darren.Ye wrote:

quoted

From: Darren Ye <redacted>

Add mt8196 audio AFE document.

A nit, subject: drop second/last, redundant "document".
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

Since you asked what did you miss from previous review (and I replied
that EVERYTHING) then maybe this will help:

How did you implement this?

quoted

Signed-off-by: Darren Ye <redacted>

...

quoted

+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - mediatek,vlpcksys
+  - power-domains
+  - memory-region
+  - clocks
+  - clock-names

Keep the same order as in properties:.

How did you implement this?

Reviewed-by: Krzysztof Kozlowski <redacted>

How did you implement this?

<form letter>
This is an automated instruction, just in case, because many review tags
are being ignored. If you know the process, you can skip it (please do
not feel offended by me posting it here - no bad intentions intended).
If you do not know the process, here is a short explanation:

Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions
of patchset, under or above your Signed-off-by tag, unless patch changed
significantly (e.g. new properties added to the DT bindings). Tag is
"received", when provided in a message replied to you on the mailing
list. Tools like b4 can help here. However, there's no need to repost
patches *only* to add the tags. The upstream maintainer will do that for
tags received on the version they apply.

Full context and explanation:
https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577

How did you implement this?

Does such questions help you to find what was missing?

Best regards,
Krzysztof