Re: [PATCH 1/1] dt-bindings: mmc: mxs-mmc: change ref to mmc-controller-common.yaml from mmc-controller.yaml
From: Stefan Wahren <wahrenst@gmx.net>
Date: 2025-05-29 08:08:53
Also in:
imx, linux-devicetree, linux-mmc, lkml
Hi Frank, thanks for the patch. Am 29.05.25 um 00:24 schrieb Frank Li:
Change ref to mmc-controller-common.yaml from mmc-controller.yaml because imx23/imx28 use dual mode controller (spi and mmc). So default dts node name use spi instead of mmc. The legancy reason, it use difference
legacy reason ?
quoted hunk ↗ jump to hunk
compatible string to distringuish work mode (spi / mmc). Fix below CHECK_DTB warnings: arch/arm/boot/dts/nxp/mxs/imx23-olinuxino.dtb: spi@80010000 (fsl,imx23-mmc): $nodename:0: 'spi@80010000' does not match '^mmc(@.*)?$' Additional add clocks property. Signed-off-by: Frank Li <Frank.Li@nxp.com> --- Documentation/devicetree/bindings/mmc/mxs-mmc.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)diff --git a/Documentation/devicetree/bindings/mmc/mxs-mmc.yaml b/Documentation/devicetree/bindings/mmc/mxs-mmc.yaml index 32e512a68ed61..ca40ca92f858d 100644 --- a/Documentation/devicetree/bindings/mmc/mxs-mmc.yaml +++ b/Documentation/devicetree/bindings/mmc/mxs-mmc.yaml@@ -17,7 +17,7 @@ description: | and the properties used by the mxsmmc driver. allOf: - - $ref: mmc-controller.yaml + - $ref: mmc-controller-common.yaml# properties: compatible:@@ -31,6 +31,9 @@ properties: interrupts: maxItems: 1 + clocks: + maxItems: 1 +
The patch looks good, but shouldn't "clocks" be a required property ?
dmas:
maxItems: 1