Hi Rob,
    Thanks for your reply.

On 2025/5/14 21:10, Rob Herring wrote:

[ EXTERNAL EMAIL ]

On Wed, May 14, 2025 at 03:01:33PM +0800, Xianwei Zhao wrote:

quoted

Add pinctrl device to support Amlogic S7.

Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
---
  arch/arm64/boot/dts/amlogic/amlogic-s7.dtsi | 81 +++++++++++++++++++++++++++++
  1 file changed, 81 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/amlogic-s7.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-s7.dtsi
index f0c172681bd1..924f10aff269 100644
--- a/arch/arm64/boot/dts/amlogic/amlogic-s7.dtsi
+++ b/arch/arm64/boot/dts/amlogic/amlogic-s7.dtsi

@@ -6,6 +6,7 @@
  #include <dt-bindings/interrupt-controller/irq.h>
  #include <dt-bindings/interrupt-controller/arm-gic.h>
  #include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/pinctrl/amlogic,pinctrl.h>

  / {
       cpus {

@@ -94,6 +95,86 @@ uart_b: serial@7a000 {
                               clock-names = "xtal", "pclk", "baud";
                               status = "disabled";
                       };
+
+                     periphs_pinctrl: pinctrl {

If you have non-boolean ranges, then this should have a unit address
(@4000).

Will add a unit address for node.

quoted

+                             compatible = "amlogic,pinctrl-s7";
+                             #address-cells = <2>;
+                             #size-cells = <2>;

Doesn't look like you need 64-bits of address and size. 1 cell is
enough.

Krzysztof raised this question in the definition of binding stage.
https://lore.kernel.org/all/012cfaca-e8f5-4614-9393-a4a46a797adb@amlogic.com/ (local)

quoted

+                             ranges = <0x0 0x0 0x0 0x4000 0x0 0x340>;