On Wed, Mar 26, 2025 at 03:54:47PM +0900, Krzysztof Wilczyński wrote:

Hello,

[...]

quoted

quoted

So I guess without this patch, we incorrectly ignore link-down
interrupts on J784S4.  It's good to have a one-sentence motivation
like that somewhere in the commit log that we can pull out and include
in the merge commit log and the pull request.

Yes, we can prepend the following to the existing commit message:
"Link down interrupts on J784S4 SoC are missed because..."

resulting in the following updated paragraph in the commit message:
Link down interrupts on J784S4 SoC are missed because commit under Fixes
assigned the value of 'linkdown_irq_regfield' for the....

How does this look like?

  https://web.git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=controller/j721e&id=b97b5b8cb603a4ba6b3f7f1b6065fa76e69bdb56

Let me know if you want any changes.

I will suggest minor changes to the first paragraph of the commit
message resulting in the following paragraph:

Commit under Fixes assigned the value of .linkdown_irq_regfield for the
J784S4 SoC as the "LINK_DOWN" macro corresponding to BIT(1), and as a
result, the Link Down interrupts on J784S4 SoC are missed.

Regards,
Siddharth.