Hi Stefan,
On 18:34 Thu 20 Feb , Andrea della Porta wrote:
Hi Stefan,
On 15:21 Sat 08 Feb , Stefan Wahren wrote:
quoted
Hi Andrea,
Am 07.02.25 um 22:31 schrieb Andrea della Porta:
quoted
+ msix_cfg_set(rp1, hwirq, MSIX_CFG_IACK_EN);
+ rp1->level_triggered_irq[hwirq] = true;
+ break;
+ case IRQ_TYPE_EDGE_RISING:
+ msix_cfg_clr(rp1, hwirq, MSIX_CFG_IACK_EN);
+ rp1->level_triggered_irq[hwirq] = false;
+ break;
+ default:
+ return -EINVAL;
It would be nice to document why only IRQ_TYPE_LEVEL_HIGH and
IRQ_TYPE_EDGE_RISING are supported. In case it's a software limitation,
this function would be a good place. In case this is a hardware
limitation this should be in the binding.
All ints are level-triggered. I guess I should add a short comment in
the bindings.
Quick errata: s/level-triggered/active high/
Thanks,
Andrea