Thread (28 messages) 28 messages, 4 authors, 2025-03-23

Re: [PATCH v7 08/11] misc: rp1: RaspberryPi RP1 misc driver

From: Andrea della Porta <andrea.porta@suse.com>
Date: 2025-03-18 11:04:01
Also in: linux-clk, linux-devicetree, linux-gpio, linux-pci, lkml

Hi Stefan,

On 18:34 Thu 20 Feb     , Andrea della Porta wrote:
Hi Stefan,

On 15:21 Sat 08 Feb     , Stefan Wahren wrote:
quoted
Hi Andrea,

Am 07.02.25 um 22:31 schrieb Andrea della Porta:
quoted
+		msix_cfg_set(rp1, hwirq, MSIX_CFG_IACK_EN);
+		rp1->level_triggered_irq[hwirq] = true;
+	break;
+	case IRQ_TYPE_EDGE_RISING:
+		msix_cfg_clr(rp1, hwirq, MSIX_CFG_IACK_EN);
+		rp1->level_triggered_irq[hwirq] = false;
+		break;
+	default:
+		return -EINVAL;
It would be nice to document why only IRQ_TYPE_LEVEL_HIGH and
IRQ_TYPE_EDGE_RISING are supported. In case it's a software limitation,
this function would be a good place. In case this is a hardware
limitation this should be in the binding.
All ints are level-triggered. I guess I should add a short comment in
the bindings.
Quick errata: s/level-triggered/active high/

Thanks,
Andrea
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help