Re: [PATCH v7 03/11] dt-bindings: pci: Add common schema for devices accessible through PCI BARs
From: Andrea della Porta <andrea.porta@suse.com>
Date: 2025-03-11 14:35:45
Also in:
linux-clk, linux-devicetree, linux-gpio, linux-pci, lkml
Hi Rob, On 08:32 Tue 11 Mar , Rob Herring wrote:
On Mon, Mar 10, 2025 at 4:21 PM Krzysztof Wilczynski [off-list ref] wrote:quoted
Hello, [...]quoted
diff --git a/MAINTAINERS b/MAINTAINERS index d45c88955072..af2e4652bf3b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS@@ -19752,6 +19752,7 @@ RASPBERRY PI RP1 PCI DRIVER M: Andrea della Porta <andrea.porta@suse.com> S: Maintained F: Documentation/devicetree/bindings/clock/raspberrypi,rp1-clocks.yaml +F: Documentation/devicetree/bindings/pci/pci-ep-bus.yaml F: Documentation/devicetree/bindings/pinctrl/raspberrypi,rp1-gpio.yaml F: include/dt-bindings/clock/rp1.h F: include/dt-bindings/misc/rp1.hI would be happy to pick this via the PCI tree as per the standard operating procedure. However, the MAINTAINERS changes do not exist for us yet, and are added in the first patch of the series, which is not ideal. I can add the missing dependency manually, but that would cause issues for linux-next tree, which is also not ideal. I saw some review feedback, as such, when you are going to be sending another version, can you make MAINTAINERS changes to be the last patch, perhaps. Basically, something standalone that perhaps whoever will pick the misc patch could also pick and apply at the same time. Alternatively, someone else picking up the PCI dt-bindings would work, too. Your thoughts?I guess I missed this in review, but why is a common schema buried in a device maintainer entry? Also, an entry in MAINTAINERS is redundant anyway because get_maintainers.pl can fetch maintainers from the schema file.
Oh nice, I've added all that .yaml entries in MAINTAINERS because I saw many reference already existing there, so I was thinking that was a good behaviour. Now I guess I can get rid of all .yaml references in MAINTAINERS file from all my patches, since they will be solved automatically by get_mainatainer.pl... There's only one minor caveat though: I have a middle name, and it turns out that get_maintainer.pl is skipping my first name. Unluckily I'm not a Perl guy so I guess I have to dive a little bit in Perl regex and send a separate patch for that. Many thanks, Andrea
Rob