Re: [PATCH] PCI: brcmstb: Adjust message if L23 cannot be entered

On Thu, Feb 13, 2025 at 07:59:38PM +0100, Stefan Wahren wrote:

Hi Mani,

Am 08.02.25 um 14:22 schrieb Stefan Wahren:

quoted

Hi Mani,

Am 08.02.25 um 11:27 schrieb Manivannan Sadhasivam:

quoted

On Sat, Feb 01, 2025 at 01:14:20PM +0100, Stefan Wahren wrote:

quoted

The entering of L23 lower-power state is optional, because the
connected endpoint might doesn't support it. So pcie-brcmstb shouldn't
print an error if it fails.

Which part of the PCIe spec states that the L23 Ready state is optional?

tbh i don't have access to the PCIe spec, so my statement based on
this comment [1].

Please tell, how can we proceed here? In case L23 is required by the
specs the driver also need adjustment.

I don't think the spec mentions that the L23 Ready state is optional. Atleast, I
cannot find the reference. In that case, I do not see a reason to drop the
error.

- Mani

-- 
மணிவண்ணன் சதாசிவம்