[PATCH] PCI: brcmstb: Adjust message if L23 cannot be entered
From: Stefan Wahren <wahrenst@gmx.net>
Date: 2025-02-01 12:15:59
Also in:
linux-pci
Subsystem:
broadcom bcm2711/bcm2835 arm architecture, broadcom bcm7xxx arm architecture, broadcom stb pcie driver, pci native host bridge and endpoint drivers, pci subsystem, the rest · Maintainers:
Florian Fainelli, Jim Quinlan, Lorenzo Pieralisi, Krzysztof Wilczyński, Manivannan Sadhasivam, Bjorn Helgaas, Linus Torvalds
The entering of L23 lower-power state is optional, because the connected endpoint might doesn't support it. So pcie-brcmstb shouldn't print an error if it fails. Signed-off-by: Stefan Wahren <wahrenst@gmx.net> --- drivers/pci/controller/pcie-brcmstb.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c
index e733a27dc8df..9e7c5349c6c2 100644
--- a/drivers/pci/controller/pcie-brcmstb.c
+++ b/drivers/pci/controller/pcie-brcmstb.c@@ -1399,7 +1399,10 @@ static void brcm_pcie_remove_bus(struct pci_bus *bus) pcie->sr = NULL; } -/* L23 is a low-power PCIe link state */ +/* + * Try to enter L23 ( low-power PCIe link state ) + * This might fail if connected endpoint doesn't support it. + */ static void brcm_pcie_enter_l23(struct brcm_pcie *pcie) { void __iomem *base = pcie->base;
@@ -1422,7 +1425,7 @@ static void brcm_pcie_enter_l23(struct brcm_pcie *pcie) } if (!l23) - dev_err(pcie->dev, "failed to enter low-power link state\n"); + dev_dbg(pcie->dev, "Unable to enter low-power link state\n"); } static int brcm_phy_cntl(struct brcm_pcie *pcie, const int start) --
2.34.1