Thread (34 messages) 34 messages, 5 authors, 2025-02-27

Re: [PATCH v2 7/7] iommu: Turn iova_cookie to dma-iommu private pointer

From: Jason Gunthorpe <jgg@nvidia.com>
Date: 2025-02-26 19:18:22
Also in: linux-iommu, linux-kselftest, linux-patches, lkml

On Wed, Feb 26, 2025 at 10:57:00AM -0800, Nicolin Chen wrote:
OK, I see. But we are also changing the behavior for the
!CONFIG_IOMMU_DMA configuration, in which case all other iommu
functions seem to return -ENODEV. And I assume we would need a
justification for such a change?

Perhaps, this can be explicit, just to keep the consistency:
	/* NOP if IOMMU driver reports SW_MSI reserved regions */
	return IS_ENABLED(CONFIG_IOMMU_DMA) ? 0 : -ENODEV;
Hurm, I donno, if we don't have a IRQ driver that supports it then it
doesn't matter that IOMMU_DMA is off either because there is nothing
that would call into IOMMU_DMA in the first place.

Success still seems like the right answer on such a weirdo kconfig.

Jason
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help