Re: [PATCH v2 7/7] iommu: Turn iova_cookie to dma-iommu private pointer
From: Nicolin Chen <hidden>
Date: 2025-02-26 02:25:48
Also in:
linux-iommu, linux-kselftest, linux-patches, lkml
On Fri, Feb 21, 2025 at 10:39:59AM -0400, Jason Gunthorpe wrote:
quoted hunk ↗ jump to hunk
diff --git a/include/linux/iommu.h b/include/linux/iommu.h index 99dd72998cb7f7..082274e8ba6a3d 100644 --- a/include/linux/iommu.h +++ b/include/linux/iommu.h@@ -1534,12 +1534,16 @@ void iommu_debugfs_setup(void); static inline void iommu_debugfs_setup(void) {} #endif -#ifdef CONFIG_IOMMU_DMA +#if defined(CONFIG_IOMMU_DMA) && IS_ENABLED(CONFIG_IRQ_MSI_IOMMU) int iommu_get_msi_cookie(struct iommu_domain *domain, dma_addr_t base); +void iommu_put_msi_cookie(struct iommu_domain *domain); #else /* CONFIG_IOMMU_DMA */ static inline int iommu_get_msi_cookie(struct iommu_domain *domain, dma_addr_t base) { - return -ENODEV; + return 0;
Should we keep the -ENODEV here for !CONFIG_IOMMU_DMA? Nicolin