Thread (29 messages) 29 messages, 4 authors, 2025-03-05

Re: [PATCH 5/8] pwm: stm32-lp: add support for stm32mp25

From: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Date: 2025-02-25 16:23:31
Also in: linux-devicetree, linux-iio, linux-pwm, lkml


On 2/25/25 13:04, Krzysztof Kozlowski wrote:
On Mon, Feb 24, 2025 at 07:01:47PM +0100, Fabrice Gasnier wrote:
quoted
 	}
 
 	return pinctrl_pm_select_sleep_state(dev);
@@ -246,6 +413,7 @@ static DEFINE_SIMPLE_DEV_PM_OPS(stm32_pwm_lp_pm_ops, stm32_pwm_lp_suspend,
 
 static const struct of_device_id stm32_pwm_lp_of_match[] = {
 	{ .compatible = "st,stm32-pwm-lp", },
+	{ .compatible = "st,stm32mp25-pwm-lp", },
No driver data suggests device is backwards compatible. Commit msg
suggests not, so that's confusing.

The LPTimer PWM driver takes benefit of the MFD parent driver to feed in
data, e.g. 'num_cc_chans'. Number of channels is now variable, on
STM32MP25 (e.g. not a single channel). But it can't be hard-coded as
compatible data. (there's only 1 channel on earlier LP Timer hardware
revision).

The hardware controller is a bit different, hence the new compatible.

Best regards,
Fabrice
Best regards,
Krzysztof
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help