Re: [PATCH v5 -next 08/11] PCI: brcmstb: Adding a softdep to MIP MSI-X driver
From: Bjorn Helgaas <helgaas@kernel.org>
Date: 2025-02-21 21:40:37
Also in:
linux-devicetree, linux-pci, lkml
On Mon, Jan 20, 2025 at 03:01:16PM +0200, Stanimir Varbanov wrote:
In case brcmstb PCIe driver and MIP MSI-X interrupt controller drivers are built as modules there could be a race in probing. To avoid this add a softdep to MIP driver to guarantee that MIP driver will be load first.
Maybe this one too? Should this be moved to after the irq_bcm2712_mip driver is added, but before brcmstb will claim bcm2712? I just want to avoid bisection problems when possible, and it sounds like if we lose the race, interrupts might not work as expected?
quoted hunk ↗ jump to hunk
Signed-off-by: Stanimir Varbanov <redacted> --- v4 -> v5: - New patch in the series. drivers/pci/controller/pcie-brcmstb.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c index 03396a9d97be..744fe1a4cf9c 100644 --- a/drivers/pci/controller/pcie-brcmstb.c +++ b/drivers/pci/controller/pcie-brcmstb.c@@ -1997,3 +1997,4 @@ module_platform_driver(brcm_pcie_driver); MODULE_LICENSE("GPL"); MODULE_DESCRIPTION("Broadcom STB PCIe RC driver"); MODULE_AUTHOR("Broadcom"); +MODULE_SOFTDEP("pre: irq_bcm2712_mip");-- 2.47.0