Re: [PATCH v5 -next 04/11] PCI: brcmstb: Reuse config structure
From: Krzysztof Wilczyński <hidden>
Date: 2025-02-21 16:41:45
Also in:
linux-devicetree, linux-pci, lkml
From: Krzysztof Wilczyński <hidden>
Date: 2025-02-21 16:41:45
Also in:
linux-devicetree, linux-pci, lkml
Hello,
quoted
quoted
Instead of copying fields from pcie_cfg_data structure to brcm_pcie reference it directly.
[...]
Sorry for the late notice but I get a compilation error on this commit:
drivers/pci/controller/pcie-brcmstb.c: In function 'brcm_pcie_turn_off':
drivers/pci/controller/pcie-brcmstb.c:1492:14: error: 'struct
brcm_pcie' has no member named 'bridge_sw_init_set'; did you mean
'bridge_reset'?
ret = pcie->bridge_sw_init_set(pcie, 1);
^~~~~~~~~~~~~~~~~~
bridge_reset
make[5]: *** [scripts/Makefile.build:194:
drivers/pci/controller/pcie-brcmstb.o] Error 1
It appears to be fixed with the subsequent commit "PCI: brcmstb: Add
bcm2712 support".
Can you please look into this and see if you get the same results?I applied this series to controller/brcmstb recently. As such, we can fix the issue directly on the branch, there will be no need to send a new version. That said, I can wait for Stanimir to see about a fix or look into this myself if needed. The 0-day bot will pick this now, and I expect it to have the same build issue. Krzysztof