Re: [PATCH v6 00/14] Add eDP support for RK3588

Hello Piotr,

On Thu, Feb 13, 2025 at 03:54:00PM +0100, Piotr Oniszczuk wrote:

quoted

Wiadomość napisana przez Damon Ding [off-list ref] w dniu 23 sty 2025, o godz. 11:07:

Picked from:
https://patchwork.kernel.org/project/linux-rockchip/list/?series=923593

These patchs have been tested with a 1536x2048p60 eDP panel on
RK3588S EVB1 board, and HDMI 1080P/4K display also has been verified
on RK3588 EVB1 board. Furthermore, the eDP display has been rechecked
on RK3399 sapphire excavator board.

Patch 1~4   are preparations for the RK3588 eDP support on both Analogix
           side and Rockchip side.
Patch 5~8  are to support to get panel from the DP AUX bus.
Patch 9~11 are the RK3588 Analogix DP driver support.
Patch 12    is to add the power sequencing delays for panel model
           LP079QX1-SP0V.
Patch 13    is the addition of RK3588 eDP0 node.
Patch 14    is to enable the eDP0 display on RK3588S EVB1 board.

Damon Ding (14):
 drm/rockchip: analogix_dp: Replace DRM_...() functions with drm_...()
 drm/rockchip: analogix_dp: Use formalized struct definition for grf
   field
 drm/rockchip: analogix_dp: Expand device data to support multiple edp
   display
 drm/bridge: analogix_dp: Add support for phy configuration.
 dt-bindings: display: rockchip: analogix-dp: Add support to get panel
   from the DP AUX bus
 drm/bridge: analogix_dp: support to get &analogix_dp_device.plat_data
   and &analogix_dp_device.aux
 drm/bridge: analogix_dp: Add support to get panel from the DP AUX bus
 drm/rockchip: analogix_dp: Add support to get panel from the DP AUX
   bus
 dt-bindings: display: rockchip: analogix-dp: Add support for RK3588
 drm/bridge: analogix_dp: Add support for RK3588
 drm/rockchip: analogix_dp: Add support for RK3588
 drm/edp-panel: Add LG Display panel model LP079QX1-SP0V
 arm64: dts: rockchip: Add eDP0 node for RK3588
 arm64: dts: rockchip: Enable eDP0 display on RK3588S EVB1 board

.../rockchip/rockchip,analogix-dp.yaml        |  25 +-
arch/arm64/boot/dts/rockchip/rk3588-base.dtsi |  28 +++
.../boot/dts/rockchip/rk3588s-evb1-v10.dts    |  54 ++++
.../drm/bridge/analogix/analogix_dp_core.c    |  76 +++---
.../drm/bridge/analogix/analogix_dp_core.h    |   1 +
.../gpu/drm/bridge/analogix/analogix_dp_reg.c |  52 ++++
drivers/gpu/drm/panel/panel-edp.c             |   8 +
.../gpu/drm/rockchip/analogix_dp-rockchip.c   | 238 +++++++++++++-----
include/drm/bridge/analogix_dp.h              |   8 +-
9 files changed, 401 insertions(+), 89 deletions(-)

-- 
2.34.1

Damon,

I’m playing with hdmi0 port enablement on radxa rock5 itx board with 6.14 mainline.

rock5 itx has 2 hdmi ports: hdmi0 is wired to rk3588 typeC1/eDP1
eDP with ra620 eDP->HDMI converter and hdmi1 from hdmi/edp tx1
(see page3 & page29 at
https://dl.radxa.com/rock5/5itx/v1110/radxa_rock_5itx_v1110_schematic.pdf)

The RK3588 has two different DP controllers. The one handled in this
series should get the eDP port running, which is routed to the
"eDP Panel" in the block diagram on page 3 of the Rock 5 ITX schematics.
So this series adds support for using "HDMI/eDP TX0" and "HDMI/eDP TX1"
in DP mode.

The port routed to HDMI0 via RA620 is the other DP controller, which
also exists twice: "TYPEC0/DP0" and "TYPEC1/DP1". This DP controller
is not yet supported upstream and there is no pending patchset. As far
as I know Rockchip plans to work on preparing upstream support for that
soon.

Note, that the two DisplayPort controllers are completely different.
The HDMI/eDP controller is a design from Analogix and the TypeC/DP
controller is a design from Synopsys.

P.S.: Heiko merged support for HDMI1 (RK3588 SoC level) recently. So you
should be able to get that running by some DT additions to the Rock 5
ITX board DT with the latest linux-next code :)

Greetings,

-- Sebastian