Hello Junhao,

On 2025-01-13 09:18, Junhao Xie wrote:

On 2025/1/13 12:25, Dragan Simic wrote:

quoted

On 2025-01-12 23:16, Junhao Xie wrote:

quoted

On 2025/1/12 16:47, Dragan Simic wrote:

quoted

Unless the design of the board is proprietary, it would be good
to provide a link to the board schematic, for those interested
in verifying the board DT file.

As a note, I already tried to find the board schematic with no
success, so the design might be proprietary.

Yes, this board is proprietary. I asked the manufacturer and
they don't provide schematics.

But I found a partial schematic diagram of some of connectors
on the board here
https://dl.ariaboard.com/photonicat_rk3568/Photonicat%20rk3568%20EVB%20Board%20spec.pdf

Yes, I also found that PDF file.  It's somewhat similar to what
Raspberry Pi provides with its reduced schematics -- helpful to
an extent, but still leaving a lot to be desired.

Out of curiosity, what did you actually use as a reference to create
the board dts file?  Perhaps some downstream dts file provided by
the manufacturer or found in some operating system image?

I wrote this device tree based on other rk3568 devices in mainline,
and downstream board dts:
https://github.com/photonicat/rockchip_rk3568_kernel/blob/novotech-5.10/arch/arm64/boot/dts/rockchip/rk3568-photonicat-base.dtsi

Thanks for the clarification.  It would be good to include that
link in the description of patch 3/3, for future reference.