Thread (15 messages) 15 messages, 4 authors, 2025-01-13

Re: [PATCH v6 3/3] arm64: dts: rockchip: add dts for Ariaboard Photonicat RK3568

From: Chukun Pan <hidden>
Date: 2025-01-12 08:20:47
Also in: linux-devicetree, linux-rockchip, lkml

Hi,
+	/* pi6c pcie clock generator */
+	vcc3v3_pi6c: regulator-vcc3v3-pi6c {
+		compatible = "regulator-fixed";
+		enable-active-high;
+		gpios = <&gpio0 RK_PA6 GPIO_ACTIVE_HIGH>;
Although both gpio and gpios can be used here, I tend 
to use gpio to keep it consistent with other parts.
(vcc3v3_sd, vcc3v4_rf, vcc5v0_usb30_otg0 ...)
+&mdio1 {
+	rgmii_phy1: ethernet-phy@0 {
Only one rgmii phy I think '1' is not needed?
Or `phy@address: ethernet-phy@address {`
+		compatible = "ethernet-phy-ieee802.3-c22";
+		reg = <0x0>;
The phy address should be 3. Can you try it?
+		pinctrl-names = "default";
+		pinctrl-0 = <&eth1_phy_rst>;
Is pinctrl necessary here?
+&sdmmc1 {
+   ...
+	wifi: wifi@1 {
+   ...
+&uart1 {
+   ...
+	bluetooth: bluetooth {
No aliases needed.

-- 
2.25.1

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help