Re: [PATCH v2 5/8] dt-bindings: display: vop2: Add rk3576 support
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2024-12-29 10:13:42
Also in:
dri-devel, linux-devicetree, linux-iommu, linux-phy, linux-rockchip, lkml
On Sat, Dec 28, 2024 at 08:21:48PM +0800, Andy Yan wrote:
quoted hunk ↗ jump to hunk
From: Andy Yan <andy.yan@rock-chips.com> Add vop found on rk3576, the main difference between rk3576 and the previous vop is that each VP has its own interrupt line. Signed-off-by: Andy Yan <andy.yan@rock-chips.com> --- Changes in v2: - describe constraint SOC by SOC, as interrupts of rk3576 is very different from others - Drop Krzysztof's Reviewed-by, as this version changed a lot. Changes in v1: - ordered by soc name - Add description for newly added interrupt .../display/rockchip/rockchip-vop2.yaml | 70 +++++++++++++++---- 1 file changed, 56 insertions(+), 14 deletions(-)diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml index 2531726af306..f28cea4a6d82 100644 --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml@@ -20,6 +20,7 @@ properties: enum: - rockchip,rk3566-vop - rockchip,rk3568-vop + - rockchip,rk3576-vop - rockchip,rk3588-vop reg:@@ -37,10 +38,22 @@ properties: - const: gamma-lut interrupts: - maxItems: 1 - description: - The VOP interrupt is shared by several interrupt sources, such as - frame start (VSYNC), line flag and other status interrupts. + minItems: 1 + maxItems: 4 + items: + - description:
That's contradictory. min/max say 1-4, but here you list two interrupts.
+ vop system interrupt, such as bus error, and vsync for vop version under + rk3576. + - description: + independent interrupts for each video port, such as vsync and other video + port related error interrupts. + + interrupt-names: + items: + - const: vop-sys + - const: vop-vp0 + - const: vop-vp1 + - const: vop-vp2
And this says exactly 4. Best regards, Krzysztof