Thread (23 messages) 23 messages, 7 authors, 2024-12-20

Re: [PATCH v6 2/7] mfd: nxp-siul2: add support for NXP SIUL2

From: Andrei Stefanescu <hidden>
Date: 2024-12-20 13:16:15
Also in: imx, linux-devicetree, linux-gpio, lkml

Hi Mark, Lee,

Thank you for your review!

On 13/12/2024 19:15, Lee Jones wrote:
On Wed, 11 Dec 2024, Mark Brown wrote:
quoted
On Wed, Dec 11, 2024 at 12:45:56PM +0000, Lee Jones wrote:
quoted
Seeing as the vast majority of this 400 line driver pertains to Regmap
handling (!), would you be kind enough to cast your expert eye over it
please?
Is there something specific you're concerned about there?  It looks like
it's just data which should be fine.
Just the mass of complex hoop-jumping to get all of these Regmaps
registered.  But if nothing stands out to you, then it's probably okay.

Still, I can't review / take this until it's a proper MFD.
I will add the SIUL2 NVMEM driver to this series in v7 then.

Best regards,
Andrei
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help