Thread (10 messages) 10 messages, 2 authors, 2024-12-09

Re: [PATCH v3 1/3] dt-bindings: mailbox: add bindings for samsung,exynos

From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2024-12-09 14:32:39
Also in: linux-devicetree, linux-samsung-soc, lkml

On 09/12/2024 15:19, Tudor Ambarus wrote:

On 12/9/24 8:33 AM, Krzysztof Kozlowski wrote:
quoted
quoted
I'm thinking of using the same driver for both cases, and differentiate
between the two by compatible and `of_device_id.data`. Thus I propose to
have a "google,gs101-acpm-mbox" compatible for the ACPM SRAM case and in
the future we may add a "google,gs101-mbox" compatible for the messages
passed via the controller's data register case.
Good that you pointed it out, I was indeed wondering why this is
"acpm-mbox", not "mbox in compatible.

This needs to be fixed - you cannot have two compatibles for the same
device.
Will fix. I followed arm,mhu, which differentiates the transfer mode,
data or doorbell, via compatible.
There was a reasoning behind: different firmware.

Best regards,
Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help