Thread (31 messages) 31 messages, 4 authors, 2024-11-23

Re: [PATCH 09/18] leds: lm3697: switch to device_for_each_child_node_scoped()

From: Andy Shevchenko <hidden>
Date: 2024-11-23 19:38:10
Also in: linux-leds, linux-mediatek, linux-sunxi, lkml

Fri, Sep 27, 2024 at 01:21:00AM +0200, Javier Carrasco kirjoitti:
Switch to device_for_each_child_node_scoped() to simplify the code by
removing the need for calls to fwnode_handle_put() in the error paths.

This also prevents possible memory leaks if new error paths are added
without the required call to fwnode_handle_put().

After switching to the scoped variant, there is no longer need for a
jump to 'child_out', as an immediate return is possible.
Same here and so on...
So, please revisit these drivers for the possible improvements.

-- 
With Best Regards,
Andy Shevchenko


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help