Thread (31 messages) 31 messages, 4 authors, 2024-11-23

Re: [PATCH 05/18] leds: cr0014114: switch to device_for_each_child_node_scoped()

From: Andy Shevchenko <hidden>
Date: 2024-11-23 19:31:18
Also in: linux-leds, linux-mediatek, linux-sunxi, lkml

Fri, Sep 27, 2024 at 01:20:56AM +0200, Javier Carrasco kirjoitti:
Switch to device_for_each_child_node_scoped() to simplify the code by
removing the need for calls to fwnode_handle_put() in the error paths.

This also prevents possible memory leaks if new error paths are added
without the required call to fwnode_handle_put().
...
 		if (ret) {
 			dev_err(priv->dev,
 				"failed to register LED device, err %d", ret);
-			fwnode_handle_put(child);
 			return ret;
Now it can be
			return dev_err_probe(..., ret, "failed to register LED device");
 		}
-- 
With Best Regards,
Andy Shevchenko


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help