Re: [PATCH v1 4/9] PCI: imx6: Correct controller_id generation logic for i.MX7D
From: Frank Li <Frank.li@nxp.com>
Date: 2024-09-24 15:31:32
Also in:
imx, linux-devicetree, linux-pci, lkml
On Tue, Sep 24, 2024 at 11:27:39AM +0800, Richard Zhu wrote:
i.MX7D only has one PCIe controller, so controller_id should always be 0. The previous code is incorrect although yielding the correct result. Fix by removing IMX7D from the switch case branch.
nit: wrap to 75 chars.
Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
quoted hunk ↗ jump to hunk
drivers/pci/controller/dwc/pci-imx6.c | 1 - 1 file changed, 1 deletion(-)diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c index e8e401729893..d49154dbb1bd 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c@@ -1338,7 +1338,6 @@ static int imx_pcie_probe(struct platform_device *pdev) switch (imx_pcie->drvdata->variant) { case IMX8MQ: case IMX8MQ_EP: - case IMX7D: if (dbi_base->start == IMX8MQ_PCIE2_BASE_ADDR) imx_pcie->controller_id = 1; break; --2.37.1