Re: [PATCH v1 1/9] dt-bindings: imx6q-pcie: Add ref clock for i.MX95 PCIe
From: Frank Li <Frank.li@nxp.com>
Date: 2024-09-24 15:23:23
Also in:
imx, linux-devicetree, linux-pci, lkml
On Tue, Sep 24, 2024 at 11:08:20AM +0100, Conor Dooley wrote:
On Tue, Sep 24, 2024 at 11:27:36AM +0800, Richard Zhu wrote:quoted
Add one ref clock for i.MX95 PCIe. Increase clocks' maxItems to 5 and keep the same restriction with other compatible string. Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>It'd be really good to mention why this clock is appearing now, when it did not before. You're just explaining what you've done, which can be seen in the diff, but not why you did it.
Previous reference clock of i.MX95 is on when system boot to kernel. But boot firmware change the behavor, so it is off when boot. So it need be turn on when it use. Also it need be turn off/on when suspend and resume. Previous miss this feature. Frank