On 29.08.24 08:12, Krzysztof Kozlowski wrote:

On Wed, Aug 28, 2024 at 08:01:17PM +0200, Jan Kiszka wrote:

quoted

From: Jan Kiszka <jan.kiszka@siemens.com>

Rewrap the long lines at this chance.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

You still have DTS packed in the middle of driver changes, suggesting
dependency.

Such ordering does not make sense, because entire DTS goes separate tree
and branch. It only complicates stuff because if you have dependency,
which you cannot have, it won't be that easily visible.

You already got the same comment.

Please fix your driver to remove dependency and ABI break, and then fix
the patch order.

Could you be a bit more precise in your review, please? Should I also
pull the last patch to front, or more all DT changes into a separate series?

The PCI driver will not fail unless you ask it for the new feature
(CONFIG_TI_PVU) AND provide an incomplete DT (DMA pools, but no VMAP regs).

Thanks,
Jan

-- 
Siemens AG, Technology
Linux Expert Center