Re: [PATCH v3 2/7] dt-bindings: PCI: ti,am65: Extend for use with PVU
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2024-08-29 06:15:01
Also in:
linux-devicetree, linux-pci, lkml
On Wed, Aug 28, 2024 at 08:01:15PM +0200, Jan Kiszka wrote:
quoted hunk ↗ jump to hunk
From: Jan Kiszka <jan.kiszka@siemens.com> The PVU on the AM65 SoC is capable of restricting DMA from PCIe devices to specific regions of host memory. Add the optional property "memory-regions" to point to such regions of memory when PVU is used. Since the PVU deals with system physical addresses, utilizing the PVU with PCIe devices also requires setting up the VMAP registers to map the Requester ID of the PCIe device to the CBA Virtual ID, which in turn is mapped to the system physical address. Hence, describe the VMAP registers which are optionally unless the PVU shall used for PCIe. Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> --- CC: Lorenzo Pieralisi <lpieralisi@kernel.org> CC: "Krzysztof Wilczyński" <redacted> CC: Bjorn Helgaas <bhelgaas@google.com> CC: linux-pci@vger.kernel.org --- .../bindings/pci/ti,am65-pci-host.yaml | 52 ++++++++++++++----- 1 file changed, 40 insertions(+), 12 deletions(-)diff --git a/Documentation/devicetree/bindings/pci/ti,am65-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,am65-pci-host.yaml index 0a9d10532cc8..d8182bad92de 100644 --- a/Documentation/devicetree/bindings/pci/ti,am65-pci-host.yaml +++ b/Documentation/devicetree/bindings/pci/ti,am65-pci-host.yaml@@ -19,16 +19,6 @@ properties: - ti,am654-pcie-rc - ti,keystone-pcie - reg: - maxItems: 4 - - reg-names: - items: - - const: app - - const: dbics - - const: config - - const: atu -
Properties must be defined in top-level. https://elixir.bootlin.com/linux/v6.8/source/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
quoted hunk ↗ jump to hunk
interrupts: maxItems: 1@@ -84,12 +74,48 @@ if: enum: - ti,am654-pcie-rc then: + properties: + reg: + minItems: 4 + maxItems: 6 + + reg-names: + minItems: 4 + items: + - const: app + - const: dbics + - const: config + - const: atu + - const: vmap_lp + - const: vmap_hp
This as well goes to the top.
+ + memory-region: + minItems: 1
Missing maxItems and this must be defined in top-level. Best regards, Krzysztof