Thread (23 messages) 23 messages, 4 authors, 2024-08-28

Re: [PATCH 8/8] regulator: irq_helpers: Add missing "Return" kerneldoc section

From: Chen-Yu Tsai <wenst@chromium.org>
Date: 2024-08-28 07:51:08
Also in: lkml

On Tue, Aug 27, 2024 at 10:44 PM Andy Shevchenko
[off-list ref] wrote:
On Tue, Aug 27, 2024 at 05:55:48PM +0800, Chen-Yu Tsai wrote:
quoted
kernel-doc complains about missing "Return" section for the function
regulator_irq_map_event_simple().

Add a "Return" section for it based on its behavior.
...
quoted
+ * Return: 0
"0."
Ack.
quoted
+ *
I don't think we need this blank line.
This actually changes the output. Without the blank line, they are treated
as the same paragraph. With the blank line, the next line is treated as
a separate paragraph, and put in the "Description" section.

Strictly speaking, the only return value is the 0 integer. The other
"return" values are output parameters that have been modified by the
function. I believe those should not be in the "Return" section.


ChenYu

quoted
+ * Actual regulator error and notification are passed back through @rid.
--
With Best Regards,
Andy Shevchenko
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help