Thread (23 messages) 23 messages, 4 authors, 2024-08-28

Re: [PATCH 0/8] regulator: kerneldoc section fixes

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2024-08-27 14:46:17
Also in: lkml

On Tue, Aug 27, 2024 at 05:55:40PM +0800, Chen-Yu Tsai wrote:
Hi,

Here are a bunch of kerneldoc fixes for the regulator core. This sort of
came as a request from Andy to not move code that already had warnings
You can add Reported-by: or Suggested-by to the cover letter.
without fixing said warnings. So here I'm fixing them first.

The bulk of the fixes are in the regulator core and OF code, but I also
fixed up a few bits in common code that were missing "Return" sections.
These are purely kerneldoc fixes and don't touch any actual code. I left
the devres code and helpers alone for now.
Thanks for doing this!

I briefly looked at them, the main two remarks are:
1) definite vs. indefinite article;
2) same and consistent term for negative error codes (or numbers if you
prefer).

Otherwise LGTM!

-- 
With Best Regards,
Andy Shevchenko


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help