RE: [PATCH v6 1/4] dt-bindings: clock: add ExynosAuto v920 SoC CMU bindings

Hello Krzysztof,

-----Original Message-----
From: Krzysztof Kozlowski <krzk@kernel.org>
Sent: Monday, August 19, 2024 5:20 PM
To: Sunyeal Hong <redacted>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>; Chanwoo Choi
[off-list ref]; Alim Akhtar [off-list ref]; Michael
Turquette [off-list ref]; Stephen Boyd [off-list ref]; Rob
Herring [off-list ref]; Conor Dooley [off-list ref]; linux-
samsung-soc@vger.kernel.org; linux-clk@vger.kernel.org;
devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/4] dt-bindings: clock: add ExynosAuto v920 SoC
CMU bindings

On Mon, Aug 19, 2024 at 02:24:12PM +0900, Sunyeal Hong wrote:

quoted

Add dt-schema for ExynosAuto v920 SoC clock controller.
Add device tree clock binding definitions for below CMU blocks.

- CMU_TOP
- CMU_PERIC0

Signed-off-by: Sunyeal Hong <redacted>

 +    then:

quoted

+      properties:
+        clocks:
+          items:
+            - description: External reference clock (38.4 MHz)
+            - description: CMU_PERIC0 NOC clock (from CMU_TOP)
+            - description: CMU_PERIC0 IP clock (from CMU_TOP)
+
+        clock-names:
+          items:
+            - const: oscclk
+            - const: noc
+            - const: ip
+
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: samsung,exynosautov920-cmu-peric1
+
+    then:
+      properties:
+        clocks:
+          items:
+            - description: External reference clock (38.4 MHz)
+            - description: CMU_PERIC1 NOC clock (from CMU_TOP)
+            - description: CMU_PERIC1 IP clock (from CMU_TOP)
+
+        clock-names:
+          items:
+            - const: oscclk
+            - const: noc
+            - const: ip

This is the same peric0, so combine them and clocks could be just:

items:
  - description: External reference clock (38.4 MHz)
  - description: CMU_PERICn NOC clock (from CMU_TOP)
  - description: CMU_PERICn IP clock (from CMU_TOP)

As you reviewed, I will remove the duplicates.

quoted

+
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: samsung,exynosautov920-cmu-misc
+
+    then:
+      properties:
+        clocks:
+          items:
+            - description: External reference clock (38.4 MHz)
+            - description: CMU_MISC NOC clock (from CMU_MISC)

Similarly:

- description: CMU_MISC/CMU_HSI0 NOC clock (from CMU_MISC)

Best Regards,
sunyeal