Thread (52 messages) 52 messages, 5 authors, 2024-08-14

Re: [PATCH v5 05/12] PCI: brcmstb: Use swinit reset if available

From: Stanimir Varbanov <hidden>
Date: 2024-08-09 09:53:08
Also in: linux-pci, lkml

Hi Jim,

On 8/1/24 01:28, Jim Quinlan wrote:
quoted hunk ↗ jump to hunk
The 7712 SOC adds a software init reset device for the PCIe HW.
If found in the DT node, use it.

Signed-off-by: Jim Quinlan <redacted>
---
 drivers/pci/controller/pcie-brcmstb.c | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c
index 4d68fe318178..948fd4d176bc 100644
--- a/drivers/pci/controller/pcie-brcmstb.c
+++ b/drivers/pci/controller/pcie-brcmstb.c
@@ -266,6 +266,7 @@ struct brcm_pcie {
 	struct reset_control	*rescal;
 	struct reset_control	*perst_reset;
 	struct reset_control	*bridge_reset;
+	struct reset_control	*swinit_reset;
 	int			num_memc;
 	u64			memc_size[PCIE_BRCM_MAX_MEMC];
 	u32			hw_rev;
@@ -1633,12 +1634,30 @@ static int brcm_pcie_probe(struct platform_device *pdev)
 	if (IS_ERR(pcie->bridge_reset))
 		return PTR_ERR(pcie->bridge_reset);
 
+	pcie->swinit_reset = devm_reset_control_get_optional_exclusive(&pdev->dev, "swinit");
+	if (IS_ERR(pcie->swinit_reset))
+		return PTR_ERR(pcie->swinit_reset);
+
 	ret = clk_prepare_enable(pcie->clk);
 	if (ret)
 		return dev_err_probe(&pdev->dev, ret, "could not enable clock\n");
 
 	pcie->bridge_sw_init_set(pcie, 0);
 
+	if (pcie->swinit_reset) {
+		ret = reset_control_assert(pcie->swinit_reset);
+		if (dev_err_probe(&pdev->dev, ret, "could not assert reset 'swinit'\n"))
+			goto clk_disable_unprepare;
+
+		/* HW team recommends 1us for proper sync and propagation of reset */
+		udelay(1);
Hmm, shouldn't this delay be part of .assert/.deassert reset_control
driver?  I think this detail is reset-control hw specific and the
consumers does not need to know it.
+
+		ret = reset_control_deassert(pcie->swinit_reset);
+		if (dev_err_probe(&pdev->dev, ret,
+				  "could not de-assert reset 'swinit' after asserting\n"))
+			goto clk_disable_unprepare;
+	}
+
 	ret = reset_control_reset(pcie->rescal);
 	if (dev_err_probe(&pdev->dev, ret, "failed to deassert 'rescal'\n"))
 		goto clk_disable_unprepare;
~Stan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help