Subject: Re: [PATCH 2/4] dt-bindings: reset Add AST2700 reset bindings

On 09/08/2024 07:42, Ryan Chen wrote:

quoted

quoted

quoted

+#define SCU0_RESET_PORTA_EHCI              (38)
+#define SCU0_RESET_PORTA_VHUB0             (38)

Is having 38 twice expected?
If not, why not use an enum, BTW?

Yes, it is expected. Due to 38 is shared reset for 2 usb controller.
One for EHCI, another is for vhub0. So I do define the same value.
That I can do more clear in dtsi description.
The following will be expected dtsi file descript.

No, that's confusing. Don't do this. You are hiding information that one reset is
shared. Terrible idea.

OK I can remove this.
Use #define SCU0_RESET_PORTA_USB              (38)

Best regards,
Krzysztof

************* Email Confidentiality Notice ********************
免責聲明:
本信件(或其附件)可能包含機密資訊，並受法律保護。如 台端非指定之收件者，請以電子郵件通知本電子郵件之發送者, 並請立即刪除本電子郵件及其附件和銷毀所有複印件。謝謝您的合作!

DISCLAIMER:
This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing the contents. Thank you.