Hi Nishanth,

On Tue, Aug 06, 2024 at 10:39:12AM GMT, Nishanth Menon wrote:

On 21:54-20240801, Markus Schneider-Pargmann wrote:

quoted

From: Dave Gerlach <redacted>

[...]

quoted

+	pmops->lpm_wake_reason = ti_sci_msg_cmd_lpm_wake_reason;

did you miss populating the rest of the pm ops?
	See https://lore.kernel.org/all/202408031302.28NpPykP-lkp@intel.com/ (local)

No, I didn't miss populating the pmops.

set_latency_constraint() and set_device_constraint() are only added to
pmops once the firmware capabilities are added in the next patch.
set_io_isolation() and prepare_sleep() are not added to pmops as the
usage outside of ti_sci.c is not planned. These are only used for
suspend/resume in the third patch.

I will rearrange the patches and integrate the functions required for
suspend/resume with the suspend/resume patch to avoid any build
warnings.

Best
Markus

It might be better to introduce the APIs one at a time?

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D