Thread (7 messages) 7 messages, 2 authors, 2024-08-06

Re: [PATCH v8 2/3] firmware: ti_sci: Add support for querying the firmware caps

From: Nishanth Menon <nm@ti.com>
Date: 2024-08-06 15:42:07
Also in: lkml

On 21:54-20240801, Markus Schneider-Pargmann wrote:
[...]
quoted hunk ↗ jump to hunk
 static int ti_sci_cmd_core_reboot(const struct ti_sci_handle *handle)
 {
 	struct ti_sci_info *info;
@@ -3113,6 +3172,12 @@ static void ti_sci_setup_ops(struct ti_sci_info *info)
 
 	pmops->lpm_wake_reason = ti_sci_msg_cmd_lpm_wake_reason;
 
+	if (info->fw_caps & MSG_FLAG_CAPS_LPM_DM_MANAGED) {
+		pr_debug("detected DM managed LPM in fw_caps\n");
+		ops->pm_ops.set_device_constraint = ti_sci_cmd_set_device_constraint;
+		ops->pm_ops.set_latency_constraint = ti_sci_cmd_set_latency_constraint;
pmops-> ?

Also lpm_wake_reason makes sense only if the flag is set, so
this should probably be the first patch in your series?
+	}
Side-note: please drop bouncing emails from your patch CC list.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help