Re: [PATCH 1/1] backing-file: covert to using fops->splice_write
From: Matthew Wilcox <willy@infradead.org>
Date: 2024-07-07 20:42:54
Also in:
linux-fsdevel, linux-mediatek, linux-unionfs, lkml
On Fri, Jul 05, 2024 at 04:16:39PM +0800, ed.tsai@mediatek.com wrote:
quoted hunk ↗ jump to hunk
+++ b/fs/backing-file.c@@ -280,13 +280,16 @@ ssize_t backing_file_splice_write(struct pipe_inode_info *pipe, if (WARN_ON_ONCE(!(out->f_mode & FMODE_BACKING))) return -EIO; + if (out->f_op->splice_write) + return -EINVAL;
Umm ... shouldn't this have been !out->f_op->splice_write?
ret = file_remove_privs(ctx->user_file); if (ret) return ret; old_cred = override_creds(ctx->cred); file_start_write(out); - ret = iter_file_splice_write(pipe, out, ppos, len, flags); + ret = out->f_op->splice_write(pipe, out, ppos, len, flags); file_end_write(out); revert_creds(old_cred); -- 2.18.0