Thread (5 messages) 5 messages, 3 authors, 2024-07-07

Re: [PATCH 1/1] backing-file: covert to using fops->splice_write

From: Ed Tsai (蔡宗軒) <hidden>
Date: 2024-07-05 08:20:27
Also in: linux-fsdevel, linux-mediatek, linux-unionfs, lkml

On Fri, 2024-07-05 at 16:16 +0800, ed.tsai@mediatek.com wrote:
quoted hunk ↗ jump to hunk
From: Ed Tsai <redacted>

Filesystems may define their own splice write. Therefore, use file
fops instead of invoking iter_file_splice_write() directly.

Signed-off-by: Ed Tsai <redacted>
---
 fs/backing-file.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/fs/backing-file.c b/fs/backing-file.c
index 740185198db3..687a7fae7d25 100644
--- a/fs/backing-file.c
+++ b/fs/backing-file.c
@@ -280,13 +280,16 @@ ssize_t backing_file_splice_write(struct
pipe_inode_info *pipe,
 	if (WARN_ON_ONCE(!(out->f_mode & FMODE_BACKING)))
 		return -EIO;
 
+	if (out->f_op->splice_write)
+		return -EINVAL;
+
 	ret = file_remove_privs(ctx->user_file);
 	if (ret)
 		return ret;
 
 	old_cred = override_creds(ctx->cred);
 	file_start_write(out);
-	ret = iter_file_splice_write(pipe, out, ppos, len, flags);
+	ret = out->f_op->splice_write(pipe, out, ppos, len, flags);
 	file_end_write(out);
 	revert_creds(old_cred);
 
s/covert/convert/ for subject
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help