Thread (11 messages) 11 messages, 4 authors, 2024-06-26

Re: [PATCH v4] usb: gadget: aspeed_udc: validate endpoint index for ast udc

From: Markus Elfring <hidden>
Date: 2024-06-25 15:20:53
Also in: kernel-janitors, linux-aspeed, linux-usb, lkml

quoted
quoted
quoted
quoted
We should verify the bound of the array to assure that host
may not manipulate the index to point past endpoint array.
Why did you not choose an imperative wording for your change description?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc5#n94
Markus, please stop reviewing USB patches.  This is not helpful at all,
and causes new developers extra work for no reason at all.
How does this feedback fit to the linked information source?
That is not what I wrote.
You indicated concerns according to patch review processes,
didn't you?

See also:
* Patch submission notes
  https://elixir.bootlin.com/linux/v6.10-rc5/source/Documentation/process/maintainer-tip.rst#L100

* Contributor Covenant Code of Conduct
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/code-of-conduct.rst?h=v6.10-rc5#n3

I wrote, "Please stop reviewing USB patches."

Please stop now.
I might be going to influence evolution of this software area in other ways
under other circumstances.

Regards,
Markus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help