Re: [PATCH net-next 4/6] net: bcmgenet: remove eee_enabled/eee_active in bcmgenet_get_eee()
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
Date: 2024-02-04 12:03:04
Also in:
netdev
On Fri, Feb 02, 2024 at 05:21:57PM -0800, Florian Fainelli wrote:
On 2/2/2024 5:17 PM, Florian Fainelli wrote:quoted
On 2/2/2024 1:34 AM, Russell King (Oracle) wrote:quoted
bcmgenet_get_eee() sets edata->eee_active and edata->eee_enabled from its own copy, and then calls phy_ethtool_get_eee() which in turn will call genphy_c45_ethtool_get_eee(). genphy_c45_ethtool_get_eee() will overwrite eee_enabled and eee_active with its own interpretation from the PHYs settings and negotiation result. Therefore, setting these members in bcmgenet_get_eee() is redundant, and can be removed. This also makes priv->eee.eee_active unnecessary, so remove this and use a local variable where appropriate. Signed-off-by: Russell King (Oracle) <redacted>Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com> Is not there an opportunity for no longer overriding eee_enabled as well since genphy_c45_ethtool_get_eee() will set that variable too?Scratch that comment, you are doing it in the getter.
Also, priv->eee.eee_enabled is used in bcmmii.c, so we can't get rid of it in the setter. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel