Re: [PATCH net-next 3/6] net: fec: remove eee_enabled/eee_active in fec_enet_get_eee()
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
Date: 2024-02-02 13:46:25
Also in:
netdev
On Fri, Feb 02, 2024 at 02:22:02PM +0100, Andrew Lunn wrote:
On Fri, Feb 02, 2024 at 09:33:54AM +0000, Russell King (Oracle) wrote:quoted
fec_enet_get_eee() sets edata->eee_active and edata->eee_enabled from its own copy, and then calls phy_ethtool_get_eee() which in turn will call genphy_c45_ethtool_get_eee(). genphy_c45_ethtool_get_eee() will overwrite eee_enabled and eee_active with its own interpretation from the PHYs settings and negotiation result. Therefore, setting these members in fec_enet_get_eee() is redundant. Remove this, and remove the setting of fep->eee.eee_active member which becomes a write-only variable.I _think_ p->eee_enabled becomes write only as well?
Thanks for spotting, I'll remove it in v2! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel