Thread (63 messages) 63 messages, 6 authors, 2024-02-29

Re: [PATCH 08/13] i2c: nomadik: replace jiffies by ktime for FIFO flushing timeout

From: Linus Walleij <hidden>
Date: 2024-02-19 14:53:27
Also in: linux-devicetree, linux-i2c, linux-mips, lkml

On Mon, Feb 19, 2024 at 3:38 PM Théo Lebrun [off-list ref] wrote:
Somewhat related to this patch: while writing it, I noticed the total
timeout of flush_i2c_fifo() is 10 times the timeout. Without this
series, this means 10*200ms of busywaiting!

If you have an opinion on a more sensible option for this I could add a
patch to my V2. I don't know enough to pick a sensible value.

I'm unsure if it makes sense that the timeout of flush_i2c_fifo() is a
multiple of the transfer timeout. Does it make sense that those two
timeouts are correlated?
I have a *vague* memory of the timeouts for flushing needing to be longer
but I might be mistaken. This is probably a Srinidhi or even Sachin question...
Sadly I don't have their current mail addresses.

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help