Re: [PATCH v12 2/3] PCI: dwc: Implement general suspend/resume functionality for L2/L3 transitions
From: Bjorn Helgaas <helgaas@kernel.org>
Date: 2024-02-01 17:53:57
Also in:
imx, linux-devicetree, linux-pci, lkml
On Thu, Feb 01, 2024 at 12:08:23PM -0500, Frank Li wrote:
On Thu, Feb 01, 2024 at 10:50:25AM -0600, Bjorn Helgaas wrote:quoted
On Mon, Aug 21, 2023 at 02:48:14PM -0400, Frank Li wrote:quoted
Introduce helper function dw_pcie_get_ltssm() to retrieve SMLH_LTSS_STATE. ...quoted
diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/controller/dwc/pcie-designware.h index 615660640801..91d13f9b21b1 100644 --- a/drivers/pci/controller/dwc/pcie-designware.h +++ b/drivers/pci/controller/dwc/pcie-designware.hquoted
@@ -364,6 +375,7 @@ struct dw_pcie_ops { void (*write_dbi2)(struct dw_pcie *pcie, void __iomem *base, u32 reg, size_t size, u32 val); int (*link_up)(struct dw_pcie *pcie); + enum dw_pcie_ltssm (*get_ltssm)(struct dw_pcie *pcie);This has already been applied as https://git.kernel.org/linus/4774faf854f5 ("PCI: dwc: Implement generic suspend/resume functionality"), but this .get_ltssm() pointer doesn't seem to be used anywhere. Should we remove it until we need it?Could you place hold on for a while? I am working on imx PCIe. One old imx6 may need it! If not, I will submit patch to clean it. My new patches depend on https://lore.kernel.org/imx/ZbJ+tFPn3aOYHCwf@lizhi-Precision-Tower-5810/T/#t (local) All already reviewed, could you please pick up these, so I can continue my futher work. Another https://lore.kernel.org/imx/20240201-pme_msg-v2-0-6767052fe6a4@nxp.com/T/#t (local) was under review.
OK. I don't see .get_ltssm() used in that series either. But if you will need it soon, no point in removing it right now. Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel