Re: [PATCH v12 2/3] PCI: dwc: Implement general suspend/resume functionality for L2/L3 transitions
From: Bjorn Helgaas <helgaas@kernel.org>
Date: 2024-02-01 16:50:28
Also in:
imx, linux-devicetree, linux-pci, lkml
On Mon, Aug 21, 2023 at 02:48:14PM -0400, Frank Li wrote:
Introduce helper function dw_pcie_get_ltssm() to retrieve SMLH_LTSS_STATE. ...
quoted hunk ↗ jump to hunk
diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/controller/dwc/pcie-designware.h index 615660640801..91d13f9b21b1 100644 --- a/drivers/pci/controller/dwc/pcie-designware.h +++ b/drivers/pci/controller/dwc/pcie-designware.h
quoted hunk ↗ jump to hunk
@@ -364,6 +375,7 @@ struct dw_pcie_ops { void (*write_dbi2)(struct dw_pcie *pcie, void __iomem *base, u32 reg, size_t size, u32 val); int (*link_up)(struct dw_pcie *pcie); + enum dw_pcie_ltssm (*get_ltssm)(struct dw_pcie *pcie);
This has already been applied as https://git.kernel.org/linus/4774faf854f5 ("PCI: dwc: Implement generic suspend/resume functionality"), but this .get_ltssm() pointer doesn't seem to be used anywhere. Should we remove it until we need it?
+static inline enum dw_pcie_ltssm dw_pcie_get_ltssm(struct dw_pcie *pci)
+{
+ u32 val;
+
+ if (pci->ops && pci->ops->get_ltssm)
+ return pci->ops->get_ltssm(pci);
+
+ val = dw_pcie_readl_dbi(pci, PCIE_PORT_DEBUG0);
+
+ return (enum dw_pcie_ltssm)FIELD_GET(PORT_LOGIC_LTSSM_STATE_MASK, val);
+}_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel