Re: [PATCH v3 06/17] spi: s3c64xx: remove unneeded (void *) casts in of_match_table

Hi, Sam,

Thanks for the review feedback.

On 1/26/24 20:17, Sam Protsenko wrote:

quoted

 static const struct of_device_id s3c64xx_spi_dt_match[] = {
-       { .compatible = "samsung,s3c2443-spi",
-                       .data = (void *)&s3c2443_spi_port_config,
+       {
+               .compatible = "samsung,s3c2443-spi",
+               .data = &s3c2443_spi_port_config,
        },
-       { .compatible = "samsung,s3c6410-spi",
-                       .data = (void *)&s3c6410_spi_port_config,
+       {

The braces style is not fixed. Yet that's a style patch, which on one
hand fixes the issue (unnecessary void * cast), but OTOH brings
another issue (non-canonical braces placement). Please see my comments
for your previous submission.

I've read your email and replied there that the braces were one on top
of the other even before my patch and since I don't have a preference on
whether to choose a style or the other, I kept the style as it were.

But I learnt my lesson. Mark can ignore this path when applying and I'll
submit a new version of the patch where I'll refrain myself making
alignments or changing the style.

Cheers,
ta

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel