Re: [PATCH v3 17/17] spi: s3c64xx: use bitfield access macros
From: Tudor Ambarus <tudor.ambarus@linaro.org>
Date: 2024-01-27 03:23:16
Also in:
linux-samsung-soc, linux-spi, lkml
Hi, Sam, Thanks for the review feedback! On 1/26/24 20:12, Sam Protsenko wrote:
quoted
- val |= S3C64XX_SPI_MODE_BUS_TSZ_HALFWORD; - val |= S3C64XX_SPI_MODE_CH_TSZ_HALFWORD; + val |= FIELD_PREP(S3C64XX_SPI_MODE_BUS_TSZ_MASK, + S3C64XX_SPI_MODE_BUS_TSZ_HALFWORD) | + FIELD_PREP(S3C64XX_SPI_MODE_CH_TSZ_MASK, + S3C64XX_SPI_MODE_CH_TSZ_HALFWORD);Two people complained it makes the code harder to read. Yet it's not addressed in v3. Please see my comments for your previous submission explaining what can be done, and also Andi's comment on that matter.
I kept these intentionally. Please read my reply on that matter or the cover letter to this patch set.
Also I think new patch series are being submitted a bit too fast, people might not have enough time to provide the review.
This patch set contains patches that are already reviewed or too simple to being lagged. Cheers, ta _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel