Re: [PATCH v3 06/20] dt-bindings: pinctrl: samsung: add google,gs101-pinctrl compatible
From: Peter Griffin <peter.griffin@linaro.org>
Date: 2023-11-07 12:23:24
Also in:
linux-clk, linux-devicetree, linux-gpio, linux-samsung-soc, linux-serial, linux-watchdog
Hi Rob, Thanks for your review. On Mon, 16 Oct 2023 at 14:41, Rob Herring [off-list ref] wrote:
On Wed, Oct 11, 2023 at 07:48:09PM +0100, Peter Griffin wrote:quoted
Add the "google,gs101-pinctrl" compatible to the dt-schema bindings documentation. Add maxItems of 50 for the interrupts property as gs101 can have multiple irqs. Signed-off-by: Peter Griffin <peter.griffin@linaro.org> --- .../bindings/pinctrl/samsung,pinctrl.yaml | 22 ++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-)diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml index 26614621774a..6dc648490668 100644 --- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml@@ -35,6 +35,7 @@ properties: compatible: enum: + - google,gs101-pinctrl - samsung,s3c2412-pinctrl - samsung,s3c2416-pinctrl - samsung,s3c2440-pinctrl@@ -58,7 +59,8 @@ properties: interrupts: description: Required for GPIO banks supporting external GPIO interrupts. - maxItems: 1 + minItems: 1 + maxItems: 50 power-domains: maxItems: 1@@ -134,6 +136,24 @@ allOf: minItems: 1 maxItems: 1 + - if: + properties: + compatible: + contains: + const: google,gs101-pinctrl + then: + properties: + interrupts: + description: + Required for external wakeup interrupts. List all externalIs it external GPIO interrupts or wakeup interrupts?
These are external wakeup interrupts. Looking again I believe this can be dropped entirely as re-reading samsung,pinctrl-gpio-bank.yaml we are already defining the external wake-up interrupts on each bank in gs101-pinctrl.dtsi.
quoted
+ wakeup interrupts supported by this bank. + minItems: 1 + maxItems: 50For a given SoC, I don't see how this is variable? If it is variable, how do you know which entry is what?
It isn't variable. Peter. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel