Re: [PATCH v8 26/26] arm64: dts: rockchip: rk3588s: Add DFI
From: Jagan Teki <jagan@edgeble.ai>
Date: 2023-11-23 09:38:51
Also in:
linux-devicetree, linux-pm, linux-rockchip, lkml
On Wed, 18 Oct 2023 at 11:47, Sascha Hauer [off-list ref] wrote:
quoted hunk ↗ jump to hunk
The DFI unit can be used to measure DRAM utilization using perf. Add the node to the device tree. The DFI needs a rockchip,pmu phandle to the pmu containing registers for SDRAM configuration details. This is added in this patch as well. Reviewed-by: Sebastian Reichel <redacted> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> --- Notes: Changes since v4: - new patch arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi index 5544f66c6ff41..e693a341f6f27 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi@@ -443,6 +443,11 @@ usb_host1_ohci: usb@fc8c0000 { status = "disabled"; }; + pmu1grf: syscon@fd58a000 { + compatible = "rockchip,rk3588-pmugrf", "syscon", "simple-mfd"; + reg = <0x0 0xfd58a000 0x0 0x10000>; + }; + sys_grf: syscon@fd58c000 { compatible = "rockchip,rk3588-sys-grf", "syscon"; reg = <0x0 0xfd58c000 0x0 0x1000>;@@ -1329,6 +1334,17 @@ pcie2x1l2_intc: legacy-interrupt-controller { }; }; + dfi: dfi@fe060000 { + reg = <0x00 0xfe060000 0x00 0x10000>; + compatible = "rockchip,rk3588-dfi"; + interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH 0>, + <GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH 0>, + <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH 0>, + <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH 0>; + interrupt-names = "ch0", "ch1", "ch2", "ch3";
Look like the names never documented and nor supported explicitly in the driver. Do we have any patch for fixing it in the mailing-list? arch/arm64/boot/dts/rockchip/rk3588-edgeble-neu6b-io.dtb: dfi@fe060000: 'interrupt-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/devfreq/event/rockchip,dfi.yaml# Jagan. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel