Re: [PATCH v2 00/20] Add minimal Tensor/GS101 SoC support and Oriole/Pixel6 board
From: Peter Griffin <peter.griffin@linaro.org>
Date: 2023-10-11 08:16:43
Also in:
linux-clk, linux-devicetree, linux-gpio, linux-samsung-soc, linux-serial, linux-watchdog
Hi Tudor, Thanks for your reply. On Wed, 11 Oct 2023 at 07:10, Tudor Ambarus [off-list ref] wrote:
Hi, Peter, On 10/10/23 23:49, Peter Griffin wrote:quoted
Note 3: In `dt-bindings: pinctrl: samsung: add google,gs101-pinctrl compatible` I tried to narrow the interrupts check to google,gs101-pinctrl but I still see a warning: gs101-oriole.dtb: pinctrl@174d0000: interrupts: [[0, 0, 4],[..] is too long If anyone can educate me on what I've done wrong here it would be most appreciated!I guess the initial definition of the number of interrupts should include the largest min/maxItems. I no longer see the warning with this change:
Yes that is how it was in v1. The review feedback though was to narrow the scope to just google,gs101-pinctrl compatible using if: then: else: which is what I can't get to work properly. regards, Peter.
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml index 2464bc43aacb..6dc648490668 100644--- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml@@ -59,7 +59,8 @@ properties: interrupts: description: Required for GPIO banks supporting external GPIO interrupts. - maxItems: 1 + minItems: 1 + maxItems: 50 power-domains: maxItems: 1
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel